Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-250: Updating GolangCiLint to v1.63.1 #612

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jan 8, 2025

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (4fc11cb) to head (3b7b998).

Files with missing lines Patch % Lines
controllers/nstemplateset/space_roles.go 0.00% 2 Missing ⚠️
pkg/webhook/mutatingwebhook/mutate.go 0.00% 0 Missing and 1 partial ⚠️
.../validatingwebhook/validate_rolebinding_request.go 0.00% 0 Missing and 1 partial ⚠️
.../validatingwebhook/validate_spacebindingrequest.go 0.00% 1 Missing ⚠️
.../webhook/validatingwebhook/validate_ssp_request.go 0.00% 0 Missing and 1 partial ⚠️
...g/webhook/validatingwebhook/validate_vm_request.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          29       29           
  Lines        3292     3292           
=======================================
  Hits         2686     2686           
  Misses        457      457           
  Partials      149      149           
Files with missing lines Coverage Δ
pkg/webhook/mutatingwebhook/mutate.go 56.81% <0.00%> (ø)
.../validatingwebhook/validate_rolebinding_request.go 87.64% <0.00%> (ø)
.../validatingwebhook/validate_spacebindingrequest.go 62.74% <0.00%> (ø)
.../webhook/validatingwebhook/validate_ssp_request.go 50.00% <0.00%> (ø)
...g/webhook/validatingwebhook/validate_vm_request.go 42.85% <0.00%> (ø)
controllers/nstemplateset/space_roles.go 67.50% <0.00%> (ø)

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 8, 2025

/test e2e

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 9, 2025

/test e2e
unrelated Failure (flaky)

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants