Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward context in validatingwebhooks #517

Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Jan 9, 2024

No description provided.

Signed-off-by: Francesco Ilario <[email protected]>
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
10.3% Duplication on New Code

See analysis details on SonarCloud

@openshift-ci openshift-ci bot added the approved label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #517 (7ccfbc7) into master (eac7d4c) will not change coverage.
The diff coverage is 77.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files          29       29           
  Lines        3220     3220           
=======================================
  Hits         2658     2658           
  Misses        426      426           
  Partials      136      136           
Files Coverage Δ
.../validatingwebhook/validate_rolebinding_request.go 87.64% <100.00%> (ø)
...lidatingwebhook/validate_k8simagepuller_request.go 30.95% <66.66%> (ø)
.../validatingwebhook/validate_spacebindingrequest.go 62.74% <66.66%> (ø)

Copy link

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit 37be293 into codeready-toolchain:master Jan 9, 2024
10 of 12 checks passed
@filariow filariow deleted the fix-webhhok-context branch January 10, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants