update to use email from propagated claims #514
Conversation
sbryzak
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 82.54% 82.54%
=======================================
Files 29 29
Lines 3220 3220
=======================================
Hits 2658 2658
Misses 426 426
Partials 136 136
|
| if email := getMUR.Annotations[toolchainv1alpha1.MasterUserRecordEmailAnnotationKey]; email != "" { | ||
| emails = append(emails, getMUR.Annotations[toolchainv1alpha1.MasterUserRecordEmailAnnotationKey]) | ||
| if email := getMUR.Spec.PropagatedClaims.Email; email != "" { | ||
| emails = append(emails, getMUR.Spec.PropagatedClaims.Email) |
There was a problem hiding this comment.
since you already assigned getMUR.Spec.PropagatedClaims.Email into email, you could do something like this:
| emails = append(emails, getMUR.Spec.PropagatedClaims.Email) | |
| emails = append(emails, email) |
but it's a minor thing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbryzak, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alexeykazakov unit tests were updated shortly after :) |
Related PR: codeready-toolchain/host-operator#943