Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Get config in webhook (#496)" #504

Conversation

rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Nov 13, 2023

Only needed if codeready-toolchain/toolchain-e2e#843 doesn't resolve the issue

This reverts commit fb165ea. See codeready-toolchain/toolchain-e2e#842

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
9.7% 9.7% Duplication

Copy link

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfrancisc, rajivnathan
Once this PR has been reviewed and has the lgtm label, please assign michaelkleinhenz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #504 (4910f50) into master (fb165ea) will increase coverage by 0.20%.
The diff coverage is 87.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   82.34%   82.54%   +0.20%     
==========================================
  Files          29       30       +1     
  Lines        3183     3312     +129     
==========================================
+ Hits         2621     2734     +113     
- Misses        426      441      +15     
- Partials      136      137       +1     
Files Coverage Δ
...roperatorconfig/memberoperatorconfig_controller.go 78.57% <100.00%> (ø)
...ontrollers/memberstatus/memberstatus_controller.go 94.31% <ø> (ø)
controllers/useraccount/useraccount_controller.go 83.53% <ø> (ø)
pkg/consoleplugin/consolepluginserver.go 67.64% <ø> (ø)
pkg/webhook/mutatingwebhook/vm_mutate.go 82.50% <95.23%> (+1.63%) ⬆️
controllers/memberoperatorconfig/configuration.go 85.49% <85.49%> (ø)

@rajivnathan
Copy link
Contributor Author

codeready-toolchain/toolchain-e2e#843 resolved the issue so this is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants