fix: forward context in idler reconciler #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Ilario <[email protected]>
filariow
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Signed-off-by: Francesco Ilario <[email protected]>
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 82.34% 82.39% +0.05%
==========================================
Files 29 29
Lines 3183 3193 +10
==========================================
+ Hits 2621 2631 +10
Misses 426 426
Partials 136 136
|
Comment on lines
145
to
146
| lctx, lcancel := context.WithCancel(ctx) | ||
| defer lcancel() |
There was a problem hiding this comment.
that's an error due to an improper use of log.IntoContext. let me refactor this
Signed-off-by: Francesco Ilario <[email protected]>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-merge-bot
bot
merged commit 1992c36
into
codeready-toolchain:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Ilario [email protected]