Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHTAPSRE-439: Deploy CA bundle configmap #978

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

gbenhaim
Copy link
Contributor

@gbenhaim gbenhaim commented Mar 5, 2024

Openshift will inject the CA bundle to the configmap. The configmap will be available in every tenant namespace, so tenant's pipelines would able to reach services that use private pki.

https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#nw-proxy-configure-object_configuring-a-custom-pki

Copy link

openshift-ci bot commented Mar 5, 2024

Hi @gbenhaim. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gbenhaim added a commit to gbenhaim/toolchain-e2e that referenced this pull request Mar 5, 2024
This is a test for the change introduced in codeready-toolchain/host-operator#978

Signed-off-by: gbenhaim <[email protected]>
@MatousJobanek
Copy link
Contributor

/ok-to-test

Openshift will inject the CA bundle to the configmap.
The configmap will be available in every tenant namespace, so tenant's
pipelines would able to reach services that use private pki.

 https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#nw-proxy-configure-object_configuring-a-custom-pki

Signed-off-by: gbenhaim <[email protected]>
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfrancisc
Copy link
Contributor

/retest

@gbenhaim
Copy link
Contributor Author

gbenhaim commented Mar 5, 2024

@mfrancisc is it an issue with my change or an infra issue?

@MatousJobanek
Copy link
Contributor

/retest
VPC quota

@mfrancisc
Copy link
Contributor

/retest

some strange error with the host-operator Subscription:

  conditions:
  - lastTransitionTime: "2024-03-05T15:47:22Z"
    message: all available catalogsources are healthy
    reason: AllCatalogSourcesHealthy
    status: "False"
    type: CatalogSourcesUnhealthy
  - message: 'failed to populate resolver cache from source source-toolchain-host-operator-latest/toolchain-host-05154206:
      failed to list bundles: rpc error: code = Unavailable desc = connection error:
      desc = "transport: Error while dialing dial tcp: lookup source-toolchain-host-operator-latest.toolchain-host-05154206.svc
      on 172.30.0.10:53: no such host"'
    reason: ErrorPreventedResolution
    status: "True"
    type: ResolutionFailed
  lastUpdated: "2024-03-05T15:47:22Z"

see: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/codeready-toolchain_host-operator/978/pull-ci-codeready-toolchain-host-operator-master-e2e/1765031212323180544/build-log.txt

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, gbenhaim, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2024
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #978 (49bb8c4) into master (4a5fee3) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   84.73%   84.75%   +0.01%     
==========================================
  Files          55       55              
  Lines        5039     5039              
==========================================
+ Hits         4270     4271       +1     
+ Misses        585      584       -1     
  Partials      184      184              

see 1 file with indirect coverage changes

@alexeykazakov alexeykazakov merged commit a517bb9 into codeready-toolchain:master Mar 5, 2024
11 of 12 checks passed
alexeykazakov pushed a commit to codeready-toolchain/toolchain-e2e that referenced this pull request Mar 5, 2024
This is a test for the change introduced in codeready-toolchain/host-operator#978

Signed-off-by: gbenhaim <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Francisc Munteanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants