-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHTAPSRE-439: Deploy CA bundle configmap #978
Conversation
Hi @gbenhaim. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a test for the change introduced in codeready-toolchain/host-operator#978 Signed-off-by: gbenhaim <[email protected]>
/ok-to-test |
Openshift will inject the CA bundle to the configmap. The configmap will be available in every tenant namespace, so tenant's pipelines would able to reach services that use private pki. https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#nw-proxy-configure-object_configuring-a-custom-pki Signed-off-by: gbenhaim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
@mfrancisc is it an issue with my change or an infra issue? |
/retest |
/retest some strange error with the host-operator Subscription:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, gbenhaim, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 84.73% 84.75% +0.01%
==========================================
Files 55 55
Lines 5039 5039
==========================================
+ Hits 4270 4271 +1
+ Misses 585 584 -1
Partials 184 184 |
a517bb9
into
codeready-toolchain:master
This is a test for the change introduced in codeready-toolchain/host-operator#978 Signed-off-by: gbenhaim <[email protected]> Co-authored-by: Matous Jobanek <[email protected]> Co-authored-by: Francisc Munteanu <[email protected]>
Openshift will inject the CA bundle to the configmap. The configmap will be available in every tenant namespace, so tenant's pipelines would able to reach services that use private pki.
https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#nw-proxy-configure-object_configuring-a-custom-pki