Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reduce the log verbosity of the SPC controller. #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jan 24, 2025

This is done by introducing a filter for the watch that should ignore any changes to the TCs that are only caused by the changes in the timestamps of the conditions.

FYI, I didn't create any e2e test for this because frankly, I am not sure how that would look like. There should be no change in the behavior and I don't really see a way of testing "the reconciliation shouldn't happen if I do this".

JIRA: https://issues.redhat.com/browse/KUBESAW-256

This is done by introducing a filter for the watch that
should ignore any changes to the TCs that are only caused
by the changes in the timestamps of the conditions.
Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (f35e54f) to head (bcaf647).

Files with missing lines Patch % Lines
pkg/mapper/change_filter.go 68.42% 6 Missing ⚠️
...isionerconfig/spaceprovisionerconfig_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   79.64%   79.63%   -0.01%     
==========================================
  Files          79       81       +2     
  Lines        8046     8067      +21     
==========================================
+ Hits         6408     6424      +16     
- Misses       1453     1458       +5     
  Partials      185      185              
Files with missing lines Coverage Δ
controllers/spaceprovisionerconfig/mapper.go 89.09% <100.00%> (ø)
pkg/mapper/conditions_changed.go 100.00% <100.00%> (ø)
...isionerconfig/spaceprovisionerconfig_controller.go 83.21% <0.00%> (ø)
pkg/mapper/change_filter.go 68.42% <68.42%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant