-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding domains field to auto-approval config #1013
Adding domains field to auto-approval config #1013
Conversation
Hi @dperaza4dustbit. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
0d4a036
to
061b31f
Compare
/ok-to-test |
Implements: ASC-444 Signed-off-by: David Peraza <[email protected]>
Signed-off-by: David Peraza <[email protected]>
061b31f
to
09b67fa
Compare
type: object | ||
x-kubernetes-map-type: atomic | ||
type: object | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was picked up when I rebased and generated CRD again. Looks to related to changes in this PR: https://github.com/codeready-toolchain/api/pull/411/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR needs to be merged before this one then I can rebase: https://github.com/codeready-toolchain/host-operator/pull/1000/files
I've merged #1000. So you can re-generate now. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1013 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 55 55
Lines 4844 4844
=======================================
Hits 4098 4098
Misses 573 573
Partials 173 173 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, dperaza4dustbit, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1df0605
into
codeready-toolchain:master
Implements: ASC-444
CRD change generated by api
make generate
call.