Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding domains field to auto-approval config #1013

Merged

Conversation

dperaza4dustbit
Copy link
Contributor

@dperaza4dustbit dperaza4dustbit commented Apr 21, 2024

Implements: ASC-444

CRD change generated by api make generate call.

Copy link

openshift-ci bot commented Apr 21, 2024

Hi @dperaza4dustbit. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MatousJobanek
Copy link
Contributor

/ok-to-test

@alexeykazakov
Copy link
Contributor

/ok-to-test

type: object
x-kubernetes-map-type: atomic
type: object
type: object
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was picked up when I rebased and generated CRD again. Looks to related to changes in this PR: https://github.com/codeready-toolchain/api/pull/411/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR needs to be merged before this one then I can rebase: https://github.com/codeready-toolchain/host-operator/pull/1000/files

@alexeykazakov
Copy link
Contributor

I've merged #1000. So you can re-generate now.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (76b358d) to head (a58053b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files          55       55           
  Lines        4844     4844           
=======================================
  Hits         4098     4098           
  Misses        573      573           
  Partials      173      173           

Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, dperaza4dustbit, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit 1df0605 into codeready-toolchain:master Apr 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants