Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Konflux: Allow using Project resources #1004

Merged

Conversation

ifireball
Copy link
Contributor

Expand Konflux/App Studio roles to allow using project resources.

Expand Konflux/App Studio roles to allow using project
resources.

Signed-off-by: Homaja Marisetty <[email protected]>
Signed-off-by: Barak Korren <[email protected]>
Copy link

openshift-ci bot commented Mar 28, 2024

Hi @ifireball. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mfrancisc
Copy link
Contributor

/ok-to-test

@mfrancisc
Copy link
Contributor

mfrancisc commented Mar 28, 2024

Copy link
Contributor

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ifireball
Copy link
Contributor Author

/retest-required

@ifireball
Copy link
Contributor Author

@mfrancisc can you approve please?

Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, ifireball, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #1004 (2c38ac7) into master (de95481) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files          55       55           
  Lines        5066     5066           
=======================================
  Hits         4300     4300           
  Misses        583      583           
  Partials      183      183           

@hmariset
Copy link
Contributor

@alexeykazakov @mfrancisc @filariow All checks have been passed. Can someone merge the PR?

@alexeykazakov alexeykazakov merged commit 47aa931 into codeready-toolchain:master Mar 28, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants