-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Konflux: Allow using Project resources #1004
chore: Konflux: Allow using Project resources #1004
Conversation
Expand Konflux/App Studio roles to allow using project resources. Signed-off-by: Homaja Marisetty <[email protected]> Signed-off-by: Barak Korren <[email protected]>
Hi @ifireball. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quality Gate passedIssues Measures |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/retest-required |
@mfrancisc can you approve please? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, ifireball, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1004 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 55 55
Lines 5066 5066
=======================================
Hits 4300 4300
Misses 583 583
Partials 183 183 |
@alexeykazakov @mfrancisc @filariow All checks have been passed. Can someone merge the PR? |
47aa931
into
codeready-toolchain:master
Expand Konflux/App Studio roles to allow using project resources.