Add vms to quotas

[rajivnathan]

https://issues.redhat.com/browse/SANDBOX-557

[alexeykazakov]

Just FYI. We don't really have to keep the test tier up to date. It's not used anywhere atm. We have this tier just in case we need to test something. Then we can add something new to the test tier, merge it and then promote a test user to the test tier in prod.
But it doesn't hurt to update this tier of course.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rajivnathan]

/retest

[rajivnathan]

/retest

[rsoaresd]

Hello, @rajivnathan!

The latest run failed with:

=== RUN   TestCreateVirtualMachine/vm-domain-memory-guest
    vm_webhook_test.go:88: 
        	Error Trace:	/tmp/toolchain-e2e/test/e2e/parallel/vm_webhook_test.go:88
        	Error:      	Received unexpected error:
        	            	virtualmachines.kubevirt.io "domain-memory-guest" is forbidden: exceeded quota: for-test-vm-deployments, requested: count/virtualmachines.kubevirt.io=1, used: count/virtualmachines.kubevirt.io=2, limited: count/virtualmachines.kubevirt.io=2
        	Test:       	TestCreateVirtualMachine/vm-domain-memory-guest

The penultimate run failed with:

        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAfterMigration/run_migration_setup_with_new_operator_versions_for_compatibility
    member.go:730: waiting for NSTemplateSet 'mig-parent-space' to match criteria
    host.go:1704: waiting for Space 'mig-parent-space' with matching criteria
    host.go:144: waiting for MasterUserRecord 'mig-parent-space' in namespace 'toolchain-host-28001059' to match criteria
    host.go:663: waiting for UserSignup 'mig-parent-space' in namespace 'toolchain-host-28001059' to match criteria
    member.go:1177: failed to find ClusterResourceQuota with matching criteria:

From what I saw, these errors seem to be specific to this PR:

• virtualmachines.kubevirt.io "domain-memory-guest" is forbidden: exceeded quota

• failed to find ClusterResourceQuota with matching criteria

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.5% Duplication on New Code

See analysis details on SonarCloud

[rsoaresd]

Hellooo,

The last two runs are still hitting on this error:

=== RUN   TestCreateVirtualMachine/vm-domain-memory-guest
    vm_webhook_test.go:88: 
        	Error Trace:	/tmp/toolchain-e2e/test/e2e/parallel/vm_webhook_test.go:88
        	Error:      	Received unexpected error:
        	            	virtualmachines.kubevirt.io "domain-memory-guest" is forbidden: exceeded quota: for-test-vm-deployments, requested: count/virtualmachines.kubevirt.io=1, used: count/virtualmachines.kubevirt.io=2, limited: count/virtualmachines.kubevirt.io=2
        	Test:       	TestCreateVirtualMachine/vm-domain-memory-guest

[rajivnathan]

/retest

[codecov]

Codecov Report

Merging #1002 (20345e6) into master (c9ecbf7) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   84.85%   84.87%   +0.01%     
==========================================
  Files          55       55              
  Lines        5066     5066              
==========================================
+ Hits         4299     4300       +1     
+ Misses        584      583       -1     
  Partials      183      183              

see 1 file with indirect coverage changes