KUBESAW-250: Updating GolangCiLint to v1.63.1 #1116
Conversation
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
Signed-off-by: Feny Mehta <[email protected]>
There was a problem hiding this comment.
The places where i have written // nolint:gosec , it bcoz the linter from 1.60 and above are throwing integer overflow conversion uint->Int and vice versa error , and the fix they have provided seems not working for us, probably, the long term solutions would be to fix this overflow error by not having to convert and only have one ttype of var
fbm3307
changed the title
Signed-off-by: Feny Mehta <[email protected]>
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
MatousJobanek
dismissed
their stale review
dismissing the approval as there are still things to address
Signed-off-by: Feny Mehta <[email protected]>
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
…roller.go Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
…roller.go Co-authored-by: Matous Jobanek <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
|
| @@ -46,7 +46,8 @@ func NewSpaceWithFeatureToggles(userSignup *toolchainv1alpha1.UserSignup, target | |||
| func addFeatureToggles(space *toolchainv1alpha1.Space, toggles []toolchainconfig.FeatureToggle) { | |||
| var winners []string | |||
| for _, t := range toggles { | |||
| weight := int(t.Weight()) | |||
| //the value of weight is not expected to go beyond 100 or negative , it won't overflow, hence its okay to ignore the overflow linter error | |||
There was a problem hiding this comment.
you are converting from uint (which cannot be negative on it's own) to int
| //the value of weight is not expected to go beyond 100 or negative , it won't overflow, hence its okay to ignore the overflow linter error | |
| //the value of weight is not expected to go beyond 100, it won't overflow, hence its okay to ignore the overflow linter error |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 78 78
Lines 7809 7814 +5
=======================================
+ Hits 6181 6185 +4
- Misses 1449 1450 +1
Partials 179 179
|
Updating the GolangciLint to v1.63.1 across all repos fix the Linter error which were caught as a result of upgrading the linter
Similar PRs