-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new field for TemplateObjects in TierTemplate CRD to support go template syntax #441
feat: Add new field for TemplateObjects in TierTemplate CRD to support go template syntax #441
Conversation
Co-authored-by: Alexey Kazakov <[email protected]>
…jects # Conflicts: # api/v1alpha1/tiertemplate_types.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Thank you for addressing my comments 👍
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Description
This PR introduces a new field which will enable us later to use go template syntax later for defining the tier templates.
It is the first step in the Tier Decoupling effort
Jira: https://issues.redhat.com/browse/KUBESAW-135
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator)? yesIn case of new CRD, did you the following? no
resources/setup/roles/host.yaml
in the sandbox-sre repositoryPROJECT
file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSV
file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.