Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new field for TemplateObjects in TierTemplate CRD to support go template syntax #441

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Aug 29, 2024

Description

This PR introduces a new field which will enable us later to use go template syntax later for defining the tier templates.
It is the first step in the Tier Decoupling effort

Jira: https://issues.redhat.com/browse/KUBESAW-135

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator)? yes

  3. In case of new CRD, did you the following? no

  4. In case other projects are changed, please provides PR links.

api/v1alpha1/tiertemplate_types.go Show resolved Hide resolved
api/v1alpha1/tiertemplate_types.go Show resolved Hide resolved
api/v1alpha1/tiertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/tiertemplate_types.go Show resolved Hide resolved
api/v1alpha1/tiertemplate_types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
Thank you for addressing my comments 👍

Copy link

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mfrancisc mfrancisc merged commit ca62518 into codeready-toolchain:master Sep 12, 2024
3 checks passed
@mfrancisc mfrancisc deleted the templateObjects branch September 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants