-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump kube-openapi version #421
Open
filariow
wants to merge
5
commits into
codeready-toolchain:master
Choose a base branch
from
filariow:bump-openapigen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−162
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e84a496
bump openapi-gen to latest version
filariow eb6f93e
update generate-openapi make target
filariow 3c2c0be
rebuild openapi generated file
filariow 3c535a7
Merge branch 'master' into bump-openapigen
ranakan19 228d188
Merge branch 'master' into bump-openapigen
mfrancisc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a Thought , Do we need to discuss/resolve the update to kube-openapi version as i see PR https://github.com/codeready-toolchain/api/pull/409/files from @ranakan19 updating it to some different version , and here it updates to some latest version? wont that be conflicting or may be just duplication of work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! As kube-openapi is a controller-runtime indirect dependency, maybe it's worth to merge the other PR first and then just remove the FAKE GOPATH logic with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fbm3307! I was thinking the same, but I wonder why there are no errors with the kube-openapi version you are upgrading to (which is the latest version) with the older controller-runtime version. Looking into this further.
As for merging the PR - I cannot merge the other PR untill all the other PRs across all repos are ready - so it may take another sprint or two to get to that stage. Would it be okay to wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i see, the version you are updating to is the latest one from controller-runtime, not from the version of the controller-runtime we are currently on or would like to update it. It also has a higher version golang version. Since there is no error in upgrading to the latest version, because it is an indirect dependency, you could update the kube-openapi to this version if you need it for something. If not, I'd rather keep them updated in sync with the rest of the dependencies.
The version of kube-openapi for controller-runtime v0.15 is https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.15/go.mod#L71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should definitely keep them updated in sync. Unfortunately, we'll not being able to remove FAKE GOPATH implementation until -if I'm not mistaken- [email protected].