Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GO variable in makefiles #408

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Mar 15, 2024

Description

Add the GO variable to Makefile, such that it is easier to use the preferred go version.

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes
    That should not be related to this PR, but I can see the following change in host-operator:

diff --git a/config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml b/config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml
index 2a3320c..f656976 100644
--- a/config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml
+++ b/config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml
@@ -131,6 +131,8 @@ spec:
                 description: The cluster in which the user is provisioned in If not
                   set then the target cluster will be picked automatically
                 type: string
+            required:
+            - identityClaims
             type: object
           status:
             description: UserSignupStatus defines the observed state of UserSignup
  1. In case of new CRD, did you the following? N/A

  2. In case other projects are changed, please provides PR links. N/A

Signed-off-by: Francesco Ilario <[email protected]>
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
BTW I personally use snap for quick and easy switch between different go versions when needed.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MatousJobanek MatousJobanek merged commit aab2b75 into codeready-toolchain:master Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants