Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have a URL #174

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Ensure we have a URL #174

merged 1 commit into from
Jan 26, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Nov 28, 2023

It looks like when we switched to using the VS Code desktop module the URL was no longer included, which caused the extension to query localhost if you had never logged in before, which errors and causes the configuration to never happen.

I will fix the module as well, but I figure we can check the URL in the plugin just in case. Edit: module PR: coder/modules#107

Fixes coder/coder#10896

It looks like when we switched to using the VS Code desktop module the
URL was no longer included, which caused the extension to query
localhost if you had never logged in before, which errors and causes the
configuration to never happen.

I will fix the module as well, but I figure we can check the URL in the
plugin just in case.
@matifali
Copy link
Member

@code-asher, Does this also close #173? And do we now support the seamless transition between multiple coder deployments?

@code-asher
Copy link
Member Author

code-asher commented Nov 29, 2023

It will partially support multiple deployments. If you use the "VS Code desktop" button in one deployment, then you use it in another deployment, that should work since the plugin will re-configure SSH for the new deployment. (I think this is the flow described in the #173? So we should be able to close it, if so.)

But, if you then try to re-open the previous deployment (for example from the recent menu) it will not work, because the plugin is now configured for the new deployment.

To truly support multiple deployments each deployment needs their own host in the SSH config, but right now they all use the same host coder-vscode--* so they clobber each other.

Either that or we need some way of associating a URL with a recent entry so we can re-configure SSH every time it is connected.

@code-asher code-asher merged commit 8f6737f into main Jan 26, 2024
2 checks passed
@code-asher code-asher deleted the check-url branch January 26, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open Workspace from VSCode extension
2 participants