Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trusted-origins cli argument #6319

Merged
merged 5 commits into from
Jul 19, 2023
Merged

add trusted-origins cli argument #6319

merged 5 commits into from
Jul 19, 2023

Conversation

alexthillen
Copy link
Contributor

Fixes #6064

@alexthillen alexthillen requested a review from a team as a code owner July 10, 2023 12:36
@code-asher
Copy link
Member

code-asher commented Jul 10, 2023

Thanks for the patch! Could we add a --trusted-proxy flag instead? Then if someone is dealing with a misconfigured proxy that cannot be fixed they can use --trusted-proxy 127.0.0.1 or whatever address their proxy is giving them.

@code-asher
Copy link
Member

Or maybe --trusted-origin could be better, not sure.

@alexthillen
Copy link
Contributor Author

Thanks for getting back to me. Added --trusted-origins flag instead.

@alexthillen alexthillen changed the title add disable-authenticate-origin flag add trusted-origins cli argument Jul 11, 2023
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! The * is a nice touch too.

@code-asher
Copy link
Member

Ah right we will need to update the unit test as well.

@alexthillen
Copy link
Contributor Author

Thanks for the feedback!
Updated the unit tests accordingly. They are passing now.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #6319 (5cfc0e3) into main (5c19962) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6319      +/-   ##
==========================================
- Coverage   73.67%   73.66%   -0.02%     
==========================================
  Files          31       31              
  Lines        1869     1872       +3     
  Branches      401      403       +2     
==========================================
+ Hits         1377     1379       +2     
- Misses        415      416       +1     
  Partials       77       77              
Impacted Files Coverage Δ
src/node/cli.ts 90.80% <ø> (ø)
src/node/http.ts 70.71% <66.66%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070a5a3...5cfc0e3. Read the comment docs.

@code-asher code-asher merged commit 93e60f7 into coder:main Jul 19, 2023
9 of 10 checks passed
@code-asher
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error Forbidden HttpError: Forbidden
2 participants