Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/replication naming convention #1448

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Conversation

byo
Copy link
Contributor

@byo byo commented Nov 8, 2022

No description provided.

@byo byo linked an issue Nov 8, 2022 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2022

Coverage Status

Coverage decreased (-0.02%) to 89.342% when pulling ab3e211 on fix/replication-naming-convention into f42bceb on master.

@byo byo requested review from jeroiraz and arriqaaq November 8, 2022 15:43
jeroiraz
jeroiraz previously approved these changes Nov 8, 2022
Copy link
Contributor

@jeroiraz jeroiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one backward compatibility concern related to proto spec changes

arriqaaq
arriqaaq previously approved these changes Nov 9, 2022
@byo byo marked this pull request as ready for review November 9, 2022 14:03
Bartłomiej Święcki added 4 commits November 9, 2022 16:01
Field identifiers remained the same thus the compatibility
between different server versions is preserved.

Signed-off-by: Bartłomiej Święcki <[email protected]>
@byo byo dismissed stale reviews from arriqaaq and jeroiraz via ab3e211 November 9, 2022 15:01
@byo byo force-pushed the fix/replication-naming-convention branch from ff80281 to ab3e211 Compare November 9, 2022 15:01
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

88.2% 88.2% Coverage
1.3% 1.3% Duplication

@byo byo merged commit ab3e211 into master Nov 9, 2022
@byo byo deleted the fix/replication-naming-convention branch November 10, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[replication]: avoid exposing follower wording
4 participants