Apply clippy, fix clippy errors, and do refactoring #2

kikuomax · 2024-03-06T07:05:25Z

Apply clippy and fix resulting errors
Do refactoring
Add a clippy job to the build GitHub Actions workflow
Bump version to 0.0.4

- Removes `tracing` field from `Aws` section of `Segment`. `tracing` is no longer listed in AWS documentation: https://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html#api-segmentdocuments-aws

Fixes errors produced by `cargo clippy --all-features --lib --bins --tests --examples -- -D warnings`: - Removes unused `lambda::init` and `lambda::taskRoot` - Replaces `starts_with` + `slice[p..]` → `strip_prefix` - Flips `Into<Duration> for Seconds` → `From<Seconds> for Duration` - Derives `Default` for `SamplingDecision` - Removes unnecessary `&` before str literals - Removes unncessary `use xray_lite` - Adds missing documentation comments Fixes errors produced by `cargo +nightly clippy --all-features --benches -- -D warnings`: - Removes closure calling functions without parameter

Introduces a new job `clippy` to `build` GitHub Actions workflow, which runs `clippy` check.

Makes parsing of additional key-value pairs more idiomatic in `FromStr for Header`.

Bumps the version in the installation instruction to v0.0.4.

kikuomax

I have self-reviewed the changes.

kikuomax added 6 commits March 5, 2024 16:01

chore(xray-lite): remove tracing field

59fe198

- Removes `tracing` field from `Aws` section of `Segment`. `tracing` is no longer listed in AWS documentation: https://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html#api-segmentdocuments-aws

chore(xray-lite): bump version to 0.0.4

fc0401e

chore(gha): add clippy job

56f27c4

Introduces a new job `clippy` to `build` GitHub Actions workflow, which runs `clippy` check.

test(xray-lite): test header with additional data

e740add

refactor(xray-lite): idiomatic key-value pair parse

69424f1

Makes parsing of additional key-value pairs more idiomatic in `FromStr for Header`.

kikuomax self-assigned this Mar 6, 2024

docs: update README

7a2ac2f

Bumps the version in the installation instruction to v0.0.4.

kikuomax commented Mar 6, 2024

View reviewed changes

kikuomax merged commit 821e78e into main Mar 6, 2024
8 checks passed

kikuomax deleted the clippy branch March 6, 2024 07:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply clippy, fix clippy errors, and do refactoring #2

Apply clippy, fix clippy errors, and do refactoring #2

kikuomax commented Mar 6, 2024 •

edited

Loading

kikuomax left a comment

Apply clippy, fix clippy errors, and do refactoring #2

Apply clippy, fix clippy errors, and do refactoring #2

Conversation

kikuomax commented Mar 6, 2024 • edited Loading

kikuomax left a comment

Choose a reason for hiding this comment

kikuomax commented Mar 6, 2024 •

edited

Loading