style: apply clippy --fix

codemonger-io · Nov 21, 2023 · 6b5666a · 6b5666a
1 parent 7e7d7e8
commit 6b5666a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/src/cert_policy.rs b/src/cert_policy.rs
@@ -37,7 +37,7 @@ impl<'a> CertificatePolicy<'a> {
             Self::Any { qualifiers: None }
         } else {
             Self::Specific {
-                oid: oid.into(),
+                oid,
                 qualifiers: None,
             }
         }
@@ -50,7 +50,7 @@ impl<'a> CertificatePolicy<'a> {
                 qualifiers: qualifiers.cloned(),
             },
             Self::Specific { oid, .. } => Self::Specific {
-                oid: oid.clone(),
+                oid: *oid,
                 qualifiers: qualifiers.cloned(),
             },
         }
@@ -138,9 +138,9 @@ impl<'a> core::fmt::Display for PolicyOidRef<'a> {
 }
 
 /// Reads policy from a given input.
-pub(crate) fn read_certificate_policies<'a>(
-    input: untrusted::Input<'a>,
-) -> ReadCertificatePolicies<'a> {
+pub(crate) fn read_certificate_policies(
+    input: untrusted::Input,
+) -> ReadCertificatePolicies {
     ReadCertificatePolicies {
         reader: untrusted::Reader::new(input),
     }
@@ -223,7 +223,7 @@ mod tests {
     fn any_policy_oid_ref_should_equal_specific_policy_oid_ref_referencing_any_policy() {
         assert_eq!(
             PolicyOidRef::Any,
-            PolicyOidRef::Specific(untrusted::Input::from(&ANY_POLICY_OID)),
+            PolicyOidRef::Specific(untrusted::Input::from(ANY_POLICY_OID)),
         );
     }
 

diff --git a/src/end_entity.rs b/src/end_entity.rs
@@ -76,6 +76,7 @@ impl<'a> EndEntityCert<'a> {
         &self.inner
     }
 
+    #[allow(clippy::too_many_arguments)]
     fn verify_is_valid_cert(
         &self,
         supported_sig_algs: &[&SignatureAlgorithm],
@@ -142,6 +143,7 @@ impl<'a> EndEntityCert<'a> {
     ///   (RFC 5280 Section 6.1.1 (c)). Verification fails if none of
     ///   certificate policies in this slice is valid in the policy tree. This
     ///   method is equivalent to [`verify_for_usage`] if this slice is empty.
+    #[allow(clippy::too_many_arguments)]
     pub fn verify_for_usage_with_policy_check(
         &self,
         supported_sig_algs: &[&SignatureAlgorithm],

diff --git a/tests/integration.rs b/tests/integration.rs
@@ -136,10 +136,10 @@ pub fn win_hello_attest_tpm() {
             &anchors,
             &[inter],
             None,
-            key_usage.clone(),
+            key_usage,
             &[],
             // 1.3.6.1.4.1.311.21.31
-            &[&[1 * 40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 31]],
+            &[&[40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 31]],
         )
     );
     assert_eq!(
@@ -149,10 +149,10 @@ pub fn win_hello_attest_tpm() {
             &anchors,
             &[inter],
             None,
-            key_usage.clone(),
+            key_usage,
             &[],
             // 1.3.6.1.4.1.311.21.32
-            &[&[1 * 40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 32]],
+            &[&[40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 32]],
         )
     );
     assert_eq!(
@@ -162,11 +162,11 @@ pub fn win_hello_attest_tpm() {
             &anchors,
             &[inter],
             None,
-            key_usage.clone(),
+            key_usage,
             &[],
             &[
-                &[1 * 40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 31],
-                &[1 * 40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 32],
+                &[40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 31],
+                &[40 + 3, 6, 1, 4, 1, 0x82, 55, 21, 32],
             ],
         )
     );