Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit news posts grabbed from the forums and fix deployment. #402

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

lonnieezell
Copy link
Collaborator

No description provided.

@lonnieezell
Copy link
Collaborator Author

Seeing all of the failures - looks like we need remove older PHP versions from our scripts since we are serving on 8.1, we don't care if they pass on previous versions.

Personally, I think we can ignore these errors and get this fix out and fix that in a separate PR.

Copy link
Contributor

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

$ composer test
> phpunit
PHPUnit 9.6.13 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.23
Configuration: /Users/kenji/work/codeigniter/official/ci4-website/phpunit.xml
Random Seed:   1695960489

...................................                               35 / 35 (100%)

Nexus\PHPUnit\Extension\Tachycardia identified these 5 slow tests:
+--------------------------------------------------+---------------+-------------+
| Test Case                                        | Time Consumed | Time Limit  |
+--------------------------------------------------+---------------+-------------+
| BasicPagesTest::testCanViewContribute            | 00:00:02.86   | 00:00:00.50 |
| BasicPagesTest::testCanViewHome                  | 00:00:02.68   | 00:00:00.50 |
| BasicPagesTest::testCanViewDownload              | 00:00:01.27   | 00:00:00.50 |
| App\\Entities\\GitHub\\GitHubTest::testResolving | 00:00:01.02   | 00:00:00.50 |
| BlogLibraryTest::testGetPostSuccess              | 00:00:00.59   | 00:00:00.50 |
+--------------------------------------------------+---------------+-------------+


Time: 00:10.047, Memory: 20.00 MB

OK (35 tests, 79 assertions)

@kenjis kenjis merged commit 0410ccc into develop Sep 29, 2023
8 of 17 checks passed
@kenjis kenjis deleted the limit-news branch September 29, 2023 04:14
@kenjis kenjis mentioned this pull request Sep 29, 2023
@kenjis
Copy link
Contributor

kenjis commented Sep 29, 2023

Seeing all of the failures - looks like we need remove older PHP versions from our scripts since we are serving on 8.1, we don't care if they pass on previous versions.

I sent PR #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants