Merge pull request #9267 from samsonasik/use-compare-empty-array

refactor: use compare empty array on Forge on keys property
codeigniter4 · Nov 12, 2024 · 1e9483c · 1e9483c
2 parents a9fa3d0 + c8b3804
commit 1e9483c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -2518,7 +2518,7 @@
 $ignoreErrors[] = [
 	// identifier: empty.notAllowed
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 13,
+	'count' => 12,
 	'path' => __DIR__ . '/system/Database/Forge.php',
 ];
 $ignoreErrors[] = [

diff --git a/system/Database/Forge.php b/system/Database/Forge.php
@@ -573,7 +573,7 @@ public function createTable(string $table, bool $ifNotExists = false, array $att
             }
 
             // Most databases don't support creating indexes from within the CREATE TABLE statement
-            if (! empty($this->keys)) {
+            if ($this->keys !== []) {
                 for ($i = 0, $sqls = $this->_processIndexes($table), $c = count($sqls); $i < $c; $i++) {
                     $this->db->query($sqls[$i]);
                 }