Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSBridge-Core-ct.11: Fix superclass of JSException #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JSBridge-Core-ct.11: Fix superclass of JSException #155

wants to merge 1 commit into from

Commits on Jan 23, 2024

  1. JSBridge-Core-ct.11: Fix superclass of JSException 

    One should (always) never subclass from Exception itself, but most of the time from Error or Notification or one of its subclasses. Exception is an abstract class, and the previous implementation led to SubclassResponsibility errors from Exception>>defaultAction when signaling a JSException. Since JavaScript errors do not have Smalltalk''s coroutine capabilities, subclassing from Error seems a perfect match in this case.
    @LinqLover
    LinqLover committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6883df1 View commit details
    Browse the repository at this point in the history