-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upgrade-version #424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halsk
commented
Jan 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とりあえず Vue2 の最終バージョンにアップした。yarn run dev でエラーは出なくなったものの、数々の Deprecation Warning が出る。
エラーの例
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div(1, $i) or calc(1 / $i)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
17 │ $fraction: 1 / $i;
│ ^^^^^^
╵
assets/sass/vendor/gridlex/_gridlex-preprocessing.scss 17:14 @import
assets/sass/vendor/gridlex/_gridlex.scss 6:9 @import
assets/sass/styles.scss 5:9 root stylesheet
あと、GitHub Actions のチェックも失敗している |
以下を除いて、ほとんどのLintエラーは修正完了。
コンポーネントから mapConfig の中身を変更しているのだが、それはバッドプラクティスなんでだめだと。 |
とりあえずメジャーなエラーは潰したのでマージする。ただし、sass のWarningは引き続き出る状況 |
This was referenced Jan 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要 | About
利用しているライブラリのバージョンをアップグレード中。Vue3 への変更には時間がかかり過ぎそうなので、一旦 Vue2 の最新版にアップする