Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade-version #424

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Feature/upgrade-version #424

merged 8 commits into from
Jan 2, 2024

Conversation

halsk
Copy link
Member

@halsk halsk commented Jan 1, 2024

概要 | About

利用しているライブラリのバージョンをアップグレード中。Vue3 への変更には時間がかかり過ぎそうなので、一旦 Vue2 の最新版にアップする

Copy link
Member Author

@halsk halsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず Vue2 の最終バージョンにアップした。yarn run dev でエラーは出なくなったものの、数々の Deprecation Warning が出る。

エラーの例

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(1, $i) or calc(1 / $i)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
17 │   $fraction: 1 / $i;
   │              ^^^^^^
   ╵
    assets/sass/vendor/gridlex/_gridlex-preprocessing.scss 17:14  @import
    assets/sass/vendor/gridlex/_gridlex.scss 6:9                  @import
    assets/sass/styles.scss 5:9                                   root stylesheet

@halsk
Copy link
Member Author

halsk commented Jan 1, 2024

あと、GitHub Actions のチェックも失敗している

@halsk
Copy link
Member Author

halsk commented Jan 2, 2024

以下を除いて、ほとんどのLintエラーは修正完了。

/Users/hal/Documents/workspace/mapprint/components/PrintableMap.vue
  264:13  error  Unexpected mutation of "mapConfig" prop  vue/no-mutating-props

✖ 1 problem (1 error, 0 warnings)

コンポーネントから mapConfig の中身を変更しているのだが、それはバッドプラクティスなんでだめだと。
ちゃんとリファクタリングしなくてはいけない状況・・・

@halsk halsk marked this pull request as ready for review January 2, 2024 05:31
@halsk
Copy link
Member Author

halsk commented Jan 2, 2024

とりあえずメジャーなエラーは潰したのでマージする。ただし、sass のWarningは引き続き出る状況

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant