Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Date and Time formats in JA #565

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix some Date and Time formats in JA #565

merged 1 commit into from
Oct 22, 2023

Conversation

takahashim
Copy link
Collaborator

🎩 What? Why?

日本語選択時の日付の表記を変更します。

ただし、#564 の日にちだけ独立して表示されるものには「日」はつきません…(formatが直接テンプレートに埋め込まれていました…)

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Before

meeting-list meeting2

After

スクリーンショット 2023-10-02 19 59 16 スクリーンショット 2023-10-02 19 57 07

@takahashim takahashim marked this pull request as ready for review October 21, 2023 14:55
@takahashim takahashim force-pushed the fix-locale-time-day-of-year branch from 9c63ce9 to c2360d0 Compare October 21, 2023 14:58
@ayuki-joto ayuki-joto merged commit 0973366 into develop Oct 22, 2023
2 checks passed
@takahashim takahashim deleted the fix-locale-time-day-of-year branch December 11, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

日本語の日付の表記がよくない場面がある
2 participants
@takahashim @ayuki-joto