Feature/update decidim v0.23.5 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
対応ありがとうございます。 |
|
これが、動く環境作成して、一度検証しないとですね |
|
このv0.23.5用ブランチを見ているのですが、Rubyのバージョンを2.7系に指定されているのは意図的でしょうか？(Gemfile.lockやDockerfile、.github/workflows/rails-test.ymlなどを見ています) 本家のv0.23.5ではGemfile.lockと.ruby-versionを見る限り、2.6.6を使っているようだったので、揃えておいた方が安全そうに見えました。 https://github.com/decidim/decidim/tree/v0.23.5 |
…ature/update-decidim_v0.23.5
…ature/update-decidim_v0.23.5
6 tasks
…into feature/update-decidim_v0.23.5
「コメントは現時点で無効になっていますが…」の表示を抑制する
Show limited number of comments, add "show all comments" button
…into feature/update-decidim_v0.23.5
takahashim
reviewed
Sep 13, 2021
config/initializers/decidim.rb
Outdated
| @@ -232,5 +232,8 @@ | |||
| Rails.application.config.i18n.available_locales = Decidim.available_locales | |||
| Rails.application.config.i18n.default_locale = Decidim.default_locale | |||
|
|
|||
| ## Set default comments limit. It's used in Decidim::Comments component. Default value is 100. | |||
| Rails.application.config.default_comments_limit = 5 | |||
This was referenced Sep 16, 2021
Closed
Use ENV var to define default_comments_limit
moved to `app/assets/javascripts/decidim/decidim_awesome/editors/legacy_quill_editor.js.es6`.
`legacy_quill_editor.js.es6` should be loaded after decidim files
Fix show comments
…into feature/update-decidim_v0.23.5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
本家 decidim の追従
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required