Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElasticBeanstalk extensions config options #128

Merged

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Nov 5, 2020

🎩 What? Why?

  • 検証環境構築の際に確認した、本番との設定の差分を取り込むためです。
    • インスタイプタイプは、本番に合わせてます。
    • ローカルからの、本番デプロイも問題なくできると思いますが、自信ないです。(試してないです)お手数ですが、確認お願いします。CI上からのstagingデプロイは問題なくできました。
    • おそらくですが、これで設定の差分がなくなるので、 最新の master を本番に適用すると JavaScript error が発生 #130 で上がっていた、下記エラーも消えると思います。

Failed Environment update activity. Reason: Configuration validation exception: RDS DB Engine Version option setting is not allowed to changed

📌 Related Issues

@komtaki komtaki force-pushed the feature/add-elasticbeanstalk-config branch from 10a9b69 to dc439e5 Compare November 5, 2020 00:36
@komtaki komtaki marked this pull request as draft November 5, 2020 11:46
@komtaki komtaki force-pushed the feature/add-elasticbeanstalk-config branch 2 times, most recently from 04e14f6 to c960480 Compare November 8, 2020 06:17
@komtaki
Copy link
Contributor Author

komtaki commented Nov 8, 2020

差分がおかしかったので、rebaseしました。:bow:

IamInstanceProfile : "aws-elasticbeanstalk-ec2-role"
EC2KeyName : "aws-eb"
InstanceType : "t2.micro"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InstanceType オプションはサポートされなくなりました。aws:ec2:instances 名前空間のより新しく強力な InstanceTypes オプションに置き換わりました。

https://docs.aws.amazon.com/ja_jp/elasticbeanstalk/latest/dg/command-options-general.html#command-options-general-rdsdbinstance

とこのことなので、移植しました。

@komtaki komtaki marked this pull request as ready for review November 8, 2020 06:21
@komtaki komtaki marked this pull request as draft November 8, 2020 07:46
@komtaki komtaki force-pushed the feature/add-elasticbeanstalk-config branch from 5b4eb9a to c960480 Compare November 8, 2020 08:35
@komtaki komtaki marked this pull request as ready for review November 8, 2020 08:35
@halsk halsk merged commit db37a40 into codeforjapan:master Nov 9, 2020
@komtaki komtaki deleted the feature/add-elasticbeanstalk-config branch November 9, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants