Merge pull request #60 from codeforjapan/fix/ecs-task-network

codeforjapan · Nov 30, 2024 · d479f3f · d479f3f
2 parents 69cc724 + bd1e9e2
commit d479f3f
Show file tree

Hide file tree

Showing 3 changed files with 117 additions and 236 deletions.
diff --git a/lib/decidim-stack.ts b/lib/decidim-stack.ts
@@ -69,6 +69,7 @@ export class DecidimStack extends cdk.Stack {
     });
 
     backendTaskRole.addToPolicy(ECSExecPolicyStatement);
+    backendTaskRole.addManagedPolicy(aws_iam.ManagedPolicy.fromAwsManagedPolicyName('service-role/AmazonECSTaskExecutionRolePolicy'));
     // backendTaskRole.addManagedPolicy(aws_iam.ManagedPolicy.fromAwsManagedPolicyName('AWSXrayWriteOnlyAccess'))
 
     // Task Definition
@@ -81,7 +82,8 @@ export class DecidimStack extends cdk.Stack {
           ? props.containerSpec?.memoryLimitMiB
           : 4096,
         family: `${ props.stage }DecidimTaskDefinition`,
-        taskRole: backendTaskRole
+        taskRole: backendTaskRole,
+        executionRole: backendTaskRole
       }
     );
 
@@ -93,7 +95,8 @@ export class DecidimStack extends cdk.Stack {
         cpu: 512,
         memoryLimitMiB: 2048,
         family: `${ props.stage }SidekiqTaskDefinition`,
-        taskRole: backendTaskRole
+        taskRole: backendTaskRole,
+        executionRole: backendTaskRole
       }
     );
 
@@ -420,8 +423,10 @@ export class DecidimStack extends cdk.Stack {
         targets: [new EcsTask({
           cluster: cluster,
           taskDefinition: taskDefinition,
+          assignPublicIp: true,
+          securityGroups: [props.securityGroup],
           subnetSelection: {
-            subnets: props.vpc.publicSubnets
+            subnetType: aws_ec2.SubnetType.PUBLIC // ここでサブネットタイプを指定
           },
           containerOverrides: [
             {