Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 20230928 #237

Merged
merged 2 commits into from
Sep 28, 2023
Merged

release 20230928 #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6385747
fix: share error
ayuki-joto Sep 27, 2023
0700868
Merge pull request #236 from codeforjapan/fix/share-error
ayuki-joto Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/organisms/completion/CompletionHeader/CompletionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import Cloud from 'components/atoms/emissions/Cloud'
import { useEmissionResult } from 'hooks/emission'

type Props = {
category: Questions.QuestionCategory
category: Questions.QuestionCategory,
shareId?: string
}

const CompletionHeader: FC<Props> = (props) => {
const result = useEmissionResult(props.category)
const result = useEmissionResult(props.category, props.shareId)
const total = useMemo(() => {
const r = result[props.category]
return r ? Math.round(r.find((m) => m.key === 'total')?.value || 0) : 0
Expand Down
2 changes: 1 addition & 1 deletion pages/category/[category]/completion/[shareId].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const CompletionPage: NextPage<Params> = ({ category, shareId }) => {

return (
<QuestionContainer category={category}>
<CompletionHeader category={category} />
<CompletionHeader category={category} shareId={shareId} />
<CompletionContent category={category} shareId={shareId} />
<Box pt={14}>
<BasicButton isNext onClick={() => router.push(process.env.NEXT_PUBLIC_SHARE_URL ?? '/')} width="full">
Expand Down