Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: クエリパラメータ名称を他エンドポイントとそろえる #128

Merged
merged 1 commit into from
Nov 2, 2024
Merged

fix: クエリパラメータ名称を他エンドポイントとそろえる #128

merged 1 commit into from
Nov 2, 2024

Conversation

sushichan044
Copy link
Collaborator

@sushichan044 sushichan044 commented Nov 1, 2024 •
edited
Loading

Outline

/notes では id 系のクエリパラメータの名称が複数形になっているが、 /posts では単数形になっている。
/posts においても複数指定できる実態を考慮すると複数形に揃えたほうが良いと判断したためそろえる。

@sushichan044 sushichan044 requested a review from yu23ki14 November 1, 2024 12:41
@sushichan044 sushichan044 self-assigned this Nov 1, 2024
@sushichan044 sushichan044 mentioned this pull request Nov 1, 2024
Merged
@yu23ki14 yu23ki14 merged commit 62a6d39 into main Nov 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu23ki14 yu23ki14 Awaiting requested review from yu23ki14

Assignees

@sushichan044 sushichan044

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushichan044 @yu23ki14