Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post.link を computed fieldにする #114

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

sushichan044
Copy link
Collaborator

Outline

closes #113
Post.linkは他のプロパティから自明に計算できる値であるため、 手動で設定せず Pydantic に計算させた方が安全

実装詳細

  • Post.link を computed fieldに変更した
    • あわせて一部既存のテストデータを修正した

@sushichan044 sushichan044 requested a review from yu23ki14 October 2, 2024 07:49
@sushichan044 sushichan044 self-assigned this Oct 2, 2024
@sushichan044 sushichan044 marked this pull request as ready for review October 2, 2024 07:49
@yu23ki14 yu23ki14 merged commit faa7668 into issue-77-post-media Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants