Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QSysFS iasp handling #2293

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix QSysFS iasp handling #2293

merged 1 commit into from
Oct 17, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #2289

Opening member located on an iasp from the member search result or from the Go to action failed because the URI would not contain the member's asp.

This PR fixes this issue by looking for the member on each known iasp if if fails to find it on *SYSBAS.
If the member is found on an iasp, the information is cached so any other member opened for the same library will automatically be done using the iasp previously found.

If a member is opened from the object browser, the library's iasp is also cached immediately to be reused if needed.

The library => iasp cache is cleared after disconnecting.

How to test this PR

  1. Search for members in a library located on an iasp
  2. Open a member from the results
  3. Use the Go to action to open a member located on an iasp

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Oct 16, 2024
@sebjulliand sebjulliand self-assigned this Oct 16, 2024
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Works perfectly - as usual...! 🥇

Approved - merge when appropriate.

@sebjulliand
Copy link
Collaborator Author

Thanks @chrjorgensen, much obliged 🥰

@sebjulliand sebjulliand merged commit 240d46e into master Oct 17, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/statIASP branch October 17, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with opening members with new version 2.13.4
2 participants