Made Java installation as connection features #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
2 tasks
|
Beautiful code change. Will get it tested ASAP. |
worksofliam
reviewed
Oct 8, 2024
worksofliam
reviewed
Oct 8, 2024
worksofliam
requested changes
Oct 8, 2024
Co-authored-by: LJ <[email protected]>
@worksofliam Can you try again? I connected to an existing system created and connected before the PR, and the reloading occurred as expected. The existing test was accurate: Or am I missing something obvious? 😅 |
worksofliam
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@sebjulliand Tested again and it worked as expected. I connected to an existing system and it grabbed the JDK correctly. Thanks!
Merge away!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR takes the Java discovery part of #2195.
The different possible Java installation locations are made into connection features.
These features are now used to get Java Home path when configuring the debug service.
How to test this PR
Checklist