Fix/bad_lines_from_member

[worksofliam]

Changes

Solves issue where source member lines that were just numerics, but had leading zeros, were not being returned correctly because the CSV was casting and interpreting those lines are numbers, and therefore removing the leading zeros/characters from the line.

How to test this PR

Examples:

1. Run the test cases
2. Run the test case created for this issue

Checklist

• have tested my change
• have created one or more test cases
• updated relevant documentation
• Remove any/all console.logs I added
• have added myself to the contributors' list in CONTRIBUTING.md

[chrjorgensen]

@worksofliam @julesyan How did you recreate this error? I'm not able to recreate it with the master branch without this change...

And there is no test case described...

Having to create test cases makes it easier to verify the code change - I thought it was tedious in the beginning but have come to appreciate it while testing other peoples code... and my own code! 😄

[chrjorgensen]

@worksofliam See my comment above... 😉

[julesyan]

@chrjorgensen i ran the steps in the test case "Ensure source lines are correct" on the master branch and on this branch. I assumed the test case itself was correct.

[worksofliam]

@chrjorgensen Here is the test case in this PR: https://github.com/codefori/vscode-ibmi/pull/2245/files#diff-bdc40b7bbc93e3369a9b963b709ed6bc8d4d9d70db7362e1f14d6edc78c07cd6R281

When recreating, make sure you have source dates enabled.

[chrjorgensen]

@julesyan @worksofliam Okay, I didn't look at the code, just saw the section "How to test this PR" above...

[sebjulliand]

Code looks good; a bit empirical but we have no choice I guess 😅
See my comment; if it's not a concern, merge away!