Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Keepalive interval login settings #2077

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

sebjulliand
Copy link
Collaborator

@sebjulliand sebjulliand commented May 27, 2024

Changes

Resolves #2074

This PR adds a new input to the Logins settings to let the user define a custom SSH Keepalive interval.
image

How to test this PR

Set a breakpoint in src/api/IBMi.ts on line 126.

  1. Open an existing connection
  2. Define a custom Keepalive interval
  3. Connect
  4. Check the connectionObject.keepaliveInterval field is set with the custom value.

Checklist

  • have tested my change

@sebjulliand sebjulliand added the enhancement New feature or request label May 27, 2024
@sebjulliand sebjulliand requested a review from chrjorgensen May 27, 2024 09:36
@sebjulliand sebjulliand self-assigned this May 27, 2024
@chrjorgensen
Copy link
Collaborator

@sebjulliand You are quick!!! 😉

I'll review it asap...

@chrjorgensen
Copy link
Collaborator

@sebjulliand Code works as expected - but the setting does not prevent the disconnect, unfortunately... 😞

I'm not sure how or if we can fix #2069... would have thought the keepalive setting was the solution, but apparantly not...

Maybe you should break this PR into two PR and isolate the other fix for private key path in its own PR?

Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand sebjulliand changed the title Added Keepalive interval login settings + fixed privatekeypath update Added Keepalive interval login settings May 29, 2024
@sebjulliand
Copy link
Collaborator Author

sebjulliand commented May 29, 2024

Maybe you should break this PR into two PR and isolate the other fix for private key path in its own PR?

@chrjorgensen absolutely. I removed the private key fix from here and put it there: #2082

@chrjorgensen chrjorgensen marked this pull request as draft May 29, 2024 11:09
@chrjorgensen
Copy link
Collaborator

absolutely. I removed the private key fix from here and put it there: #2082

@sebjulliand Great! I changed this PR to draft... when we find a solution we can continue here if necessary...

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this PR is not very good. Please do more work to make it better.

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said, not very good. Work on this more.

@worksofliam worksofliam added the build Build will be available inside PR. label Jun 4, 2024
Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam marked this pull request as ready for review June 4, 2024 15:34
Copy link
Contributor

github-actions bot commented Jun 4, 2024

👋 A new build is available for this PR based on 587bc38.

@worksofliam
Copy link
Contributor

@sebjulliand is this actually ready to be reviewed?

@sebjulliand
Copy link
Collaborator Author

@worksofliam welp, it was changed to draft since it doesn't seem to fix the original issue, even though the keepalive is adjusted (checkout @chrjorgensen comment above).

@worksofliam
Copy link
Contributor

@sebjulliand I suspect it's also related to the timeout as set by the OS. @chrjorgensen What do you see with CHGTCPA? I believe there is a timeout option there too which might be similar.

@worksofliam worksofliam marked this pull request as draft July 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build will be available inside PR. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement keep-alive setting on server connection to avoid SSH timeout
3 participants