-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control UI UX for running Actions #1522
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected.
I'll leave it to you @worksofliam or @chrjorgensen to approve the Open Output
change before merging.
Using <pre> is way better. Let's keep it simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam Code is working as expected - I only have one question:
Shouldn't the configuration setting be a global one, working for all connections? This is a UI change and I would have thought it was a global setting... ❓
@sebjulliand your change is working as expected and it's a nice addition. The search even works in the CustomUI, neat! @chrjorgensen you are completely right. I ripped out the config from the connection settings and move it into a workspace setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam LGTM - approved! 😃
Merge whenever you feel for it...
Changes
Adds a new connection setting so the user can control what UX they want when running an Action.
How to test
Checklist
console.log
s I added