Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control UI UX for running Actions #1522

Merged
merged 12 commits into from
Sep 13, 2023
Merged

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Sep 6, 2023

Changes

Adds a new connection setting so the user can control what UX they want when running an Action.

How to test

  1. Set to 'Show Action'
    • Expect only the task to show as the Action is started
  2. Set to 'Show Problems'
    • Expect only the Problems view to show when the Action has been run
  3. Set to 'None'
    • Expect no views to be shown

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam changed the title Feature/action_ux_control Control UI UX for running Actions Sep 6, 2023
@worksofliam worksofliam marked this pull request as ready for review September 7, 2023 13:17
@sebjulliand
Copy link
Collaborator

  • Pushed Open Output commit
  • Completed the description

Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected.
I'll leave it to you @worksofliam or @chrjorgensen to approve the Open Output change before merging.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam Code is working as expected - I only have one question:

Shouldn't the configuration setting be a global one, working for all connections? This is a UI change and I would have thought it was a global setting... ❓

@worksofliam
Copy link
Contributor Author

@sebjulliand your change is working as expected and it's a nice addition. The search even works in the CustomUI, neat!

@chrjorgensen you are completely right. I ripped out the config from the connection settings and move it into a workspace setting.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam LGTM - approved! 😃

Merge whenever you feel for it...

@worksofliam worksofliam merged commit f45697a into master Sep 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent update to v2.2.0 compile output to terminal window truncates compile listing
3 participants