Wait actual end of CompileTools.runAction #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebjulliand
added
the
bug
worksofliam
reviewed
Sep 6, 2023
worksofliam
previously approved these changes
Sep 6, 2023
…ction" This reverts commit 99cdf86.
|
@worksofliam there you go! |
worksofliam
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since
CompileTools.runActionnow uses task, it returns right after the task is created and started.This PR makes it wait for the actual end of the action before returning and also lets the
code-for-ibmi.runActioncommand returns the result of the action as aboolean.Checklist
console.logs I added