Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Tools namespace in CodeForIBMi API #1436

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

SanjulaGanepola
Copy link
Contributor

Changes

This PR adds the Tools namespace to the CodeForIBMi API for other extensions to use.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Copy link
Contributor

I need to verify the namespace gets exported correct so other extensions can actually use it.

@worksofliam worksofliam self-assigned this Jul 27, 2023
worksofliam
worksofliam previously approved these changes Aug 11, 2023
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@worksofliam
Copy link
Contributor

@SanjulaGanepola Any chance you can fix the conflicts? Then merge should be ok.

Signed-off-by: Sanjula Ganepola <[email protected]>
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts resolved and looks good to me! Thanks @SanjulaGanepola

@worksofliam worksofliam merged commit eb0d986 into codefori:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants