Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple change #220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simple change #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c60a3
Simple change
silkylaroux Oct 25, 2021
487cff9
Fixed lint
silkylaroux Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/api/blueprints/leads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,8 @@ def leads_number_of_pages():

def _parse_search_param(request):

return request.args.get("search")
multi_term_fix = request.args.get("search").replace(" ", "&")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This errors when "search" is not provided in the query string.

What happens is request.args.get("serach") evaluates to None, and then since None has no replace method an AttributeError gets raised.

Testing from the frontend, this happens when the search bar is empty.

return multi_term_fix


def _parse_tag_param(request):
Expand Down