Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uninstalled parcel-bundler and installed parcel. #179 #183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

uninstalled parcel-bundler and installed parcel. #179 #183

wants to merge 2 commits into from

Conversation

oliviacarino
Copy link

Description

Fixes #ISSUE

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

galbwe
galbwe reviewed Oct 15, 2021
View reviewed changes
frontend/package.json
@@ -18,7 +18,6 @@
"@mui/material": "^5.0.2",
"@types/react": "^16.8.6 || ^17.0.0",
"dotenv": "^10.0.0",
"parcel-bundler": "^1.12.5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did parcel get added to package.json? I'm not seeing it in the diffs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to stage it, my bad. Should be updated now.

@galbwe galbwe linked an issue Oct 16, 2021 that may be closed by this pull request
Update Parcel to version 2 #179
Open
galbwe
galbwe requested changes Oct 16, 2021
View reviewed changes
Copy link
Collaborator

@galbwe galbwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure yarn.lock gets updated too?

@galbwe
Copy link
Collaborator

galbwe commented Oct 16, 2021 •
edited
Loading

@oliviacarino the react app didn't start for me in development mode. You might need to update the script tag in index.html following the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galbwe galbwe galbwe requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Parcel to version 2
2 participants
@oliviacarino @galbwe