Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parcel to version 2 #179

Open
galbwe opened this issue Oct 14, 2021 · 6 comments · May be fixed by #183
Open

Update Parcel to version 2 #179

galbwe opened this issue Oct 14, 2021 · 6 comments · May be fixed by #183
Labels

Comments

@galbwe
Copy link
Collaborator

galbwe commented Oct 14, 2021

We are currently using parcel-bundler version 1, but version 2 was recently released in a different library called parcel.

  • Uninstall parcel-bundler
  • Install parcel
  • Make sure package.json scripts still work and update them if not.
  • Make sure the app can still run using both the docker-compose method and the development server methods described in the README.
@galbwe galbwe added frontend Hacktoberfest Hacktoberfest 2021 labels Oct 14, 2021
@oliviacarino
Copy link

Hi @galbwe can you assign this issue to me? Thanks!

@galbwe
Copy link
Collaborator Author

galbwe commented Oct 14, 2021

Hey @oliviacarino. Sure!

oliviacarino added a commit to oliviacarino/partner-finder that referenced this issue Oct 15, 2021
@galbwe galbwe linked a pull request Oct 16, 2021 that will close this issue
10 tasks
@galbwe
Copy link
Collaborator Author

galbwe commented Oct 21, 2021

@oliviacarino are you still working on this issue?

@oliviacarino
Copy link

@galbwe I was not able to install and use docker/docker-compose on my machine to check if the app was running okay after updating to parcel. Sorry about that, I've unassigned myself

@oliviacarino oliviacarino removed their assignment Oct 21, 2021
@galbwe
Copy link
Collaborator Author

galbwe commented Oct 21, 2021

Oh okay no worries.

@galbwe
Copy link
Collaborator Author

galbwe commented Oct 21, 2021

After looking into this a bit more, it seems like we are using multiple versions of material ui, and this causes dependency issues after upgrading parcel. After following this migration guide and running yarn dev, I get this error:

🚨 Build failed.

@parcel/core: Failed to resolve '@mui/icons-material/Instagram' from './src/components/LeadRow.js'

  /Users/wes/projects/partner-finder/frontend/src/components/LeadRow.js:9:27
     8 | import TwitterIcon from '@mui/icons-material/Twitter';
  >  9 | import InstagramIcon from '@mui/icons-material/Instagram';
  >    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    10 | import MailOutlineIcon from '@mui/icons-material/MailOutline';
    11 | import Avatar from '@material-ui/core/Avatar';

@parcel/resolver-default: Cannot find module @mui/icons-material
💡 Did you mean '@mui/material'?

Not sure how entailed fixing this will be.

@galbwe galbwe removed the Hacktoberfest Hacktoberfest 2021 label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants