Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter sidebar projects to only show active projects #332

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Filter sidebar projects to only show active projects #332

merged 1 commit into from
Aug 6, 2019

Conversation

wdoug
Copy link
Member

@wdoug wdoug commented Aug 6, 2019

This PR closes #331

What does this PR do?

As stated

How does this PR make you feel? 🔗

@wdoug wdoug requested a review from MikeLuDev August 6, 2019 02:58
dviramontes
dviramontes approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@dviramontes dviramontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

14 similar comments
@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          72       72           
  Lines         786      786           
  Branches      193      193           
=======================================
  Hits          351      351           
  Misses        432      432           
  Partials        3        3
Impacted Files Coverage Δ
src/authenticated/DrawerContent.tsx 23.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1cdac...34e45bc. Read the comment docs.

@wdoug wdoug merged commit ffdaf44 into master Aug 6, 2019
@wdoug wdoug deleted the sidebar-only-active-projects branch August 6, 2019 14:43
@shaverda
Copy link

shaverda commented Aug 6, 2019 •
edited
Loading

i know you already merged, but code lgtm, but note that #331 says that sidebar wants to show projects in active development and EXPLORATION. assuming exploration is a separate status, which I am brand new so I don't know, this code does not cover exploration. you may have changed your mind about what you want to appear on the sidebar.

@wdoug
Copy link
Member Author

wdoug commented Aug 20, 2019

Oh yeah, good catch. I'm not exactly sure what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dviramontes dviramontes dviramontes approved these changes

@MikeLuDev MikeLuDev Awaiting requested review from MikeLuDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Projects in the sidebar to only show projects in active development and exploration
4 participants
@wdoug @codecov-io @shaverda @dviramontes