Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 2021.1 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mrpippy
Copy link
Collaborator

@mrpippy mrpippy commented Dec 8, 2020

Update to 2021.1 (#16), it does build but I haven't tested it

Changes in 2021.1 from SSA:
It updates the economic data with the new automatic adjustments
announced on October 13, 2020.
@thadk
Copy link
Member

thadk commented Mar 1, 2021

I’m talking to @AlexMerritt trying to figure out a way to make a version api that gets built into the javascript version. I can’t tell right now in the frontend if I have loaded the 2021 or 2020 code built into my wasm file.

@thadk
Copy link
Member

thadk commented Mar 1, 2021

An API to const string BiprojNonFile::titletrOriginal[NUMASSUMSETS] from oactobjs32/piadata/biprojnf.cpp or const std::string AwincNonFile::titletrOriginal[NUMASSUMSETS] from oactobjs32/piadata/awincnf.cpp might be sufficient to convey what's needed, though the actual version number from the anypia32/Anypia32.rc IDD_ABOUTBOX DIALOGEX would be ideal. (All three are prominent in the changes on this PR)

@thadk
Copy link
Member

thadk commented Mar 1, 2021

Alex said "It's possible to [read the anypia32.rc file in a macro] but the correct way to manage the version numbers is to put it in the CMakeLists.txt file
Something like this
https://riptutorial.com/cmake/example/32603/using-cmake-to-define-the-version-number-for-cplusplus-usage"

@thadk
Copy link
Member

thadk commented Mar 1, 2021

I guess building from that I propose we have a version file written in CMake script and referenced in CMakeList.txt that eventually can be written by a Github action script that downloads the latest version. For now it should have this format:

project(anypiajs VERSION "2021.1")

project(anypiajs DESCRIPTION "The current version of the Detailed Calculator is 2021.1, which we released on November 20, 2020. It updates the economic data with the new automatic adjustments announced on October 13, 2020.")

Remarks are taken from the top of https://www.ssa.gov/OACT/anypia/anypia.html at $('#content > section.wrapper.py0 > div > div.cell.pa3.print-w-100.w-100.m-w-75.fs1.br > div:nth-child(1) > div > p').innerText

Maybe the project lines above could go on

?

@thadk
Copy link
Member

thadk commented Mar 10, 2021

I also troubleshooted and realized XCode 12 is making warnings into errors in the old version of Boost 1.64.0 bootstrap.sh per https://www.gitmemory.com/issue/boostorg/build/664/714882384 . Thankfully I still have an old version of XCode around to build it until I figure out how to suppress that behavior or switch boost to a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants