-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flows-config-schema.json #369
Conversation
[#185752154]
Hi @spokenbird - can you explain how to test out this change? I applied the file, as described in our readme, and am not seeing it correct me. Not sure I'm doing it correctly. |
It started working now. I am seeing the auto complete. |
"type": "string", | ||
"description": "For screen within a subflow, they need the name of the subflow defined." | ||
"description": "A method name to run on a POST." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fill this description out a little more. Something along the lines of "This is is the name of an Action method that will be called when a POST occurs, before any general data processing happens."
I think you can say Action here, so folks can link this back to what an Action is in the docs.
}, | ||
"crossFieldValidationAction": { | ||
"type": "string", | ||
"description": "A method name to to validate one field based on another field." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This is the name of an Action method that will be called after general validation is done on the fields, but before the data is saved to the database. It is a chance to do any cross field validation necessary."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also fill the rest out some more as well (the ones below this). If this is the only documentation that a SNE sees, then it's good if we give a little more context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the updates!
[#185752154]