Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to VITE #18

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Migrate to VITE #18

merged 3 commits into from
Jun 26, 2024

Conversation

ct-dixit
Copy link
Member

@ct-dixit ct-dixit commented May 23, 2024

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@ct-dixit ct-dixit requested a review from phoenixcoded20 May 23, 2024 10:25
@phoenixcoded20 phoenixcoded20 changed the title vite done Migrate to VITE Jun 25, 2024
Copy link
Contributor

@phoenixcoded20 phoenixcoded20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHeck comments. check gradient as well

.env Outdated Show resolved Hide resolved
.env.development Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@phoenixcoded20 phoenixcoded20 merged commit f47873d into main Jun 26, 2024
@phoenixcoded20 phoenixcoded20 deleted the vite branch June 26, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants