Make dailytestrollup branch nullable #365
Conversation
| @@ -404,7 +404,7 @@ class PartitioningMeta: | |||
| ) | |||
| date = models.DateField() | |||
| repoid = models.IntegerField() | |||
| branch = models.TextField() | |||
| branch = models.TextField(null=True) | |||
There was a problem hiding this comment.
@joseph-sentry I'll summon thee to see if it'd affect your work
There was a problem hiding this comment.
ah this is fine i think, it's probably crashing the test results processor at the moment, I find it weird that we have commits with no branch but i guess that's a separate issue
I'm not sure if it's better to just skip inserting into the rollups table if the branch is null though
michelletran-codecov
force-pushed
the
fix_integrity_errors
branch
from
08268e8
to
a711b12
Compare
michelletran-codecov
force-pushed
the
fix_integrity_errors
branch
from
a711b12
to
265b8e9
Compare
We've been seeing a bunch of errors related to this field not being nullable. This is because it's taking the branch from the commit, which _can_ be nullable. See: [error](https://codecov.sentry.io/share/issue/478a3e60158547b69afa0b9959822237/)
michelletran-codecov
force-pushed
the
fix_integrity_errors
branch
from
265b8e9
to
4d7c01d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 90.24% 89.81% -0.44%
==========================================
Files 384 324 -60
Lines 11735 9472 -2263
Branches 2058 1688 -370
==========================================
- Hits 10590 8507 -2083
+ Misses 1046 901 -145
+ Partials 99 64 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Admittedly, I'm not sure if this is the right solution, but we've been seeing a bunch of errors related to this field not being nullable (see error in Sentry). This is because it's taking the branch from the commit, which can be nullable.
This would also fix a bunch of errors seen in codecov/worker#729
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.