Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change flags to anchor style #3519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Nov 20, 2024

Description

Just changing links to link: "text-ds-blue-darker" to better represent there are clickable.

Closes codecov/engineering-team#2774

Screenshot 2024-11-20 at 4 24 00 PM

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.44%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 57 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.61MB 56 bytes (0.0%) ⬆️
gazebo-production-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.44%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 5.56MB 57 bytes (-0.0%) ⬇️
gazebo-staging-system-esm 5.61MB 56 bytes (0.0%) ⬆️
gazebo-staging-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4079           
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...933ebec. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 20, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3459 1 3458 0
View the top 1 failed tests by shortest run time
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions &gt; when rendered &gt; planString is set to annual plan &gt; renders annual button as &quot;selected&quot;
Stack Traces | 0.17s run time
Error: expect(element).toHaveClass(&quot;bg-ds-primary-base&quot;)

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@codecov-qa
Copy link

codecov-qa bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (21fe01f) to head (933ebec).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4079           
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...933ebec. Read the comment docs.


🚨 Try these New Features:

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (21fe01f) to head (933ebec).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4086    +7     
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...933ebec. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 20, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
63426da Wed, 20 Nov 2024 19:38:24 GMT Expired Expired
933ebec Thu, 21 Nov 2024 00:30:23 GMT Expired Expired
933ebec Thu, 21 Nov 2024 00:31:11 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flags need anchoring treatment/styling
3 participants