build: Audit and update lint rules for Gazebo #3508

nicholas-codecov · 2024-11-18T11:34:06Z

Description

This PR removes react-scripts from Gazebo, while updating the local eslint config to match that of react-scripts so that we're able to fully remove it and it's extra deps. This PR also updates some of the already used eslint packages while I was at it.

Ticket: codecov/engineering-team#2124

Notable Changes

Add/Update/Remove lint related deps
Copy lint rules over from react-scripts
- Removed deprecated
- Updated rules for unused vars - you can use _ (underscore) now to ignore unused vars
  - Update couple of warnings for unused vars
Remove Storybook create-react-app preset (since we removed react-scripts this is no longer needed)

codecov-staging · 2024-11-18T11:36:46Z

Bundle Report

Changes will increase total bundle size by 826 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.61MB	552 bytes (0.01%) ⬆️
gazebo-staging-system	5.56MB	274 bytes (0.0%) ⬆️

codecov · 2024-11-18T11:37:07Z

Bundle Report

Changes will increase total bundle size by 826 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.56MB	274 bytes (0.0%) ⬆️
gazebo-production-system-esm	5.61MB	552 bytes (0.01%) ⬆️

codecov · 2024-11-18T11:37:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (3133f8c) to head (614ae25).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.93%   98.92%   -0.01%     
==========================================
  Files         806      806              
  Lines       14369    14372       +3     
  Branches     4077     4086       +9     
==========================================
+ Hits        14216    14218       +2     
- Misses        146      147       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

... and 2 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (-0.02%)`	⬇️
Services	`99.36% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...614ae25. Read the comment docs.

codecov-notifications · 2024-11-18T11:37:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.93%   98.92%   -0.01%     
==========================================
  Files         806      806              
  Lines       14369    14372       +3     
  Branches     4077     4079       +2     
==========================================
+ Hits        14216    14218       +2     
- Misses        146      147       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

... and 2 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (-0.02%)`	⬇️
Services	`99.36% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...614ae25. Read the comment docs.

codecov-releaser · 2024-11-18T11:40:08Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`72eb6f6`	Mon, 18 Nov 2024 11:40:08 GMT	Expired	Expired
`cc027fc`	Mon, 18 Nov 2024 11:56:56 GMT	Expired	Expired
`9130e2c`	Mon, 18 Nov 2024 16:02:16 GMT	Expired	Expired
`4c9f62b`	Tue, 19 Nov 2024 11:39:14 GMT	Expired	Expired
`614ae25`	Thu, 21 Nov 2024 11:39:18 GMT	Cloud	Enterprise

codecov-qa · 2024-11-18T11:40:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (3133f8c) to head (614ae25).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.93%   98.92%   -0.01%     
==========================================
  Files         806      806              
  Lines       14369    14372       +3     
  Branches     4077     4086       +9     
==========================================
+ Hits        14216    14218       +2     
- Misses        146      147       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

... and 2 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (-0.02%)`	⬇️
Services	`99.36% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...614ae25. Read the comment docs.

🚨 Try these New Features:

JS Bundle Analysis - Avoid shipping oversized bundles

…gazebo

codecov-public-qa · 2024-11-18T12:00:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (3133f8c) to head (cc027fc).

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (3133f8c) and HEAD (cc027fc). Click for more details.

HEAD has 8 uploads less than BASE

Flag BASE (3133f8c) HEAD (cc027fc)

18 10

@@             Coverage Diff             @@
##             main    #3508       +/-   ##
===========================================
- Coverage   98.93%   86.20%   -12.73%     
===========================================
  Files         806      806               
  Lines       14369    14369               
  Branches     4084     4077        -7     
===========================================
- Hits        14216    12387     -1829     
- Misses        146     1740     +1594     
- Partials        7      242      +235

see 97 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`76.08% <ø> (-22.52%)`	⬇️
Services	`99.06% <ø> (-0.31%)`	⬇️
Shared	`98.60% <ø> (-0.74%)`	⬇️
UI	`99.14% <ø> (-0.08%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...cc027fc. Read the comment docs.

nicholas-codecov added 3 commits November 18, 2024 07:28

add new deps for eslint rules

c26bf00

update eslint related packages

e1120f3

build out eslint config based off of react-scripts lint rules

72eb6f6

nicholas-codecov marked this pull request as ready for review November 18, 2024 11:50

Merge branch 'main' into gh-eng-2124-audit-and-update-lint-rules-for-…

cc027fc

…gazebo

nicholas-codecov added 7 commits November 18, 2024 11:56

also remove storybook create-react-app preset

9130e2c

remove duplicated or deprecated rules

052d2c8

allow unused vars to be ignored with an underscore

5ee1ca4

ignore errors in catch statement with underscores

49332de

remove unused vars for their respective type declartions

2f67f48

use underscore to silence lint warning

4c9f62b

re-org rules to be split between modified base rules and custom rules

614ae25

nicholas-codecov mentioned this pull request Nov 21, 2024

build: Apply recommended lint rules #3524

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Audit and update lint rules for Gazebo #3508

build: Audit and update lint rules for Gazebo #3508

nicholas-codecov commented Nov 18, 2024 •

edited

Loading

codecov-staging bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov-notifications bot commented Nov 18, 2024 •

edited

Loading

codecov-releaser commented Nov 18, 2024 •

edited

Loading

codecov-qa bot commented Nov 18, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 18, 2024 •

edited

Loading

build: Audit and update lint rules for Gazebo #3508

Are you sure you want to change the base?

build: Audit and update lint rules for Gazebo #3508

Conversation

nicholas-codecov commented Nov 18, 2024 • edited Loading

Description

Notable Changes

codecov-staging bot commented Nov 18, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 18, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-releaser commented Nov 18, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-qa bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Nov 18, 2024 • edited Loading

Codecov Report

nicholas-codecov commented Nov 18, 2024 •

edited

Loading

codecov-staging bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov-notifications bot commented Nov 18, 2024 •

edited

Loading

codecov-releaser commented Nov 18, 2024 •

edited

Loading

codecov-qa bot commented Nov 18, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 18, 2024 •

edited

Loading