fix: Fix link to custom gh app for self-hosted #3492
Conversation
Bundle ReportChanges will decrease total bundle size by 192 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 262 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14358 +4
Branches 4075 4083 +8
=======================================
+ Hits 14224 14228 +4
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14358 +4
Branches 4075 4076 +1
=======================================
+ Hits 14224 14228 +4
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14358 +4
Branches 4082 4083 +1
=======================================
+ Hits 14224 14228 +4
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14358 +4
Branches 4082 4083 +1
=======================================
+ Hits 14224 14228 +4
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| @@ -60,7 +60,7 @@ describe('useStaticNavLinks', () => { | |||
| ${links.uploaderCLI} | ${'https://docs.codecov.com/docs/codecov-uploader#using-the-cli-to-upload-reports-with-codecovio-cloud'} | |||
| ${links.integrityCheck} | ${'https://docs.codecov.com/docs/codecov-uploader#integrity-checking-the-uploader'} | |||
| ${links.codecovGithubApp} | ${'https://github.com/apps/codecov'} | |||
There was a problem hiding this comment.
maybe replace this one too? Not sure where used
There was a problem hiding this comment.
Oh yeah good catch. I updated to pull from the var (which is set to codecov by default). It's used in some banners it looks like - I won't hide in those cases since the close-enough link is probably better than no link
|
Removed the "Switch context" row per this convo 
|
|
I'll wait for this before merging this - https://github.com/codecov/internal-issues/issues/1073 |
Self-hosted deployments (
config.IS_SELF_HOSTED, for Dedicated Enterprise Cloud customers and self-hosted) cannot use the default GitHub codecov app that can be installed from this link:https://github.com/apps/codecov/installations/select_targetInstead, that slug
codecovneeds to be replaced by the custom GitHub app name as explained in our docs hereSo something like
https://github.com/apps/my-custom-app-name/installations/select_targetNote that the slug ("GitHub App Name") is a lowercase hyphen separated string version of the entered name
Update the "Install Codecov GitHub app" link in the header to redirect to the custom app based on the existing env var (
REACT_APP_GH_APP=my-custom-app-name).Closes codecov/engineering-team#2251