-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add configured repos table to the Codecov AI tab #3303
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 98.79% 98.73% -0.06%
==========================================
Files 803 806 +3
Lines 14016 14072 +56
Branches 3913 4000 +87
==========================================
+ Hits 13847 13894 +47
- Misses 158 167 +9
Partials 11 11
... and 12 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 98.79% 98.73% -0.06%
==========================================
Files 803 806 +3
Lines 14016 14072 +56
Branches 3913 4005 +92
==========================================
+ Hits 13847 13894 +47
- Misses 158 167 +9
Partials 11 11
... and 12 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 98.79% 98.73% -0.06%
==========================================
Files 803 806 +3
Lines 14016 14072 +56
Branches 3992 4000 +8
==========================================
+ Hits 13847 13894 +47
- Misses 158 167 +9
Partials 11 11
... and 12 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 3.74kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 98.79% 98.73% -0.06%
==========================================
Files 803 806 +3
Lines 14016 14072 +56
Branches 3964 4005 +41
==========================================
+ Hits 13847 13894 +47
- Misses 158 167 +9
Partials 11 11
... and 12 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 3.74kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
|
||
const repo1Link = await screen.findByText(/repo-1/) | ||
expect(repo1Link).toBeInTheDocument() | ||
const repo2Link = await screen.findByText(/repo-1/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo-2 right?
getCoreRowModel: getCoreRowModel(), | ||
}) | ||
|
||
// This should technically never happen, but render a fallback just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how much value this comment is giving tbh :P
@@ -0,0 +1,110 @@ | |||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any taste for turning this into a vite file? Otherwise maybe we can create a followup ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I ran into some minor issues, and this is a bit time sensitive. I'll give it another try Tuesday before merging. Otherwise, will make a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries! I get it
const ResponseSchema = z.object({ | ||
owner: z | ||
.object({ | ||
aiFeaturesEnabled: z.boolean(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this always have a boolean value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
@@ -0,0 +1,110 @@ | |||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this re:vite
} | ||
|
||
return { | ||
aiEnabledRepos: parsedRes.data.owner?.aiEnabledRepos, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we default to an empty array here maybe?
Then I think we can get rid of this line in the ConfiguredRepositories component maybe?
if (!data?.aiEnabledRepos) return []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, lgtm!
Description
See design here.
If the user has already installed the app, we want to display a table with a list of repos the app is installed on.
Please note that we currently do not support pagination here, nor are we doing any server side sorting. This will be added in the future.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.