Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting GH_APP in docker #2712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

imnotjames
Copy link

Description

adds support for CODECOV_GITHUB_APP docker environment variable

fixes #2711

Code Example

docker -e CODECOV_GITHUB_APP=codecov-example some-image-reference

Notable Changes

When setting the CODECOV_GITHUB_APP, the github app linked out to when adding organizations is correct

Screenshots

N/A

Link to Sample Entry

N/A

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

@rfox-codecov rfox-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM textually but what's GH_APP for?

@imnotjames
Copy link
Author

imnotjames commented Mar 22, 2024

It sets the name of the app when you're connecting a new organization. Without this set, you'll be directed to connecting codecov which is not the GitHub app for a self hosted instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set GH_APP similar to other environment vars in start-nginx.sh
2 participants